Skip to content

Break circular dependency #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tacaswell wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Break circular dependency #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6d7cb5
MNT: break dependency cycle
tacaswell Jul 31, 2026
372d03a
DOC/CI: use dependency group in circle
tacaswell Jul 31, 2026
08811ce
ENH: add pixi package metadata
tacaswell Jul 31, 2026
a31f48c
MNT: fix version format
tacaswell Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
tag: "3.11"
steps:
- checkout
- python/install-packages:
pkg-manager: pip-dist
pip-dependency-file: docs/requirements.txt
- run:
name: Install dependencies
command: pip install --group doc -e .
- run:
name: Build docs
command: make -C docs html
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ Installing the theme itself:

After following the contribution guidelines in the Matplotlib docs, you will still need to install the theme itself to see the changes you made. At the root level of the repository run:

`python -m pip install -e .`
`python -m pip install --group doc -e .`

After that you will be able to build the docs locally by doing `make html` in the `docs` directory.
2 changes: 0 additions & 2 deletions docs/requirements.txt
View file
Open in desktop

This file was deleted.

23 changes: 22 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ classifiers = [
]
dependencies = [
"pydata-sphinx-theme==0.20.0",
"matplotlib",
"sphinx-design",
]

[dependency-groups]
doc = [
"matplotlib"
]

[project.urls]
homepage = "https://matplotlib.org/mpl-sphinx-theme/"
repository = "https://github.com/matplotlib/mpl-sphinx-theme"
Expand All @@ -50,3 +54,20 @@ mpl_sphinx_theme = [
"static/font/*.*",
"components/*.html",
]


[tool.pixi.workspace]
channels = ["conda-forge"]
platforms = ["linux-64", "osx-arm64", "osx-64", "win-64"]
preview = ["pixi-build"]


[tool.pixi.package]
version = "3.11.1.dev0"

@QuLogic QuLogic Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that right? We're probably going to forget updating this without documentation, especially if you need the micro.

@tacaswell tacaswell Jul 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dynamic versioning in pixi-build is still not working so I'm not sure what we want to do here.

name = "mpl-sphinx-theme"

[tool.pixi.package.build.backend]
name = "pixi-build-python"

[tool.pixi.package.build.config]
ignore-pypi-mapping = false