Fix PHPUnit deprecation warnings in integration tests#24271
Draft
Fix PHPUnit deprecation warnings in integration tests#24271
Conversation
tzi
added
the
not-in-changelog
sgiehl
reviewed
Mar 27, 2026
| $this->assertNotEmpty($dao->countVisitsWithDatesLimit($from, $to)); | ||
| } | ||
|
|
||
| private function assertDoesNotMatchRegularExpressionCompat(string $pattern, string $value): void |
Member
There was a problem hiding this comment.
I'm personally not a fan of adding such compat methods unless they are required. A deprecation message might be annoying, but it doesn't break things. But such a compat method might remain in the code later even if we update the phpunit library with Matomo 6. So it imho increases the risk to produce more technical debt, rather then reducing it.
But if anyone else has the opinion it's better to hide deprecations that are only visible in tests/development, I have no problem bowing to the majority.
Contributor
Author
There was a problem hiding this comment.
Let's discuss that later then!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes PHPUnit deprecation warnings in affected integration tests to improve PHPUnit 10 compatibility.
Fixes in the plugins
Checklist
Review