Introduce New Blocked Leaf Page Format - #29
Open
vidyasilai wants to merge 24 commits into
Open
Conversation
…works/turtle_kv into tastolfi/blocked-leaf-pages
…cked_leaf_page. Refactor blocked leaf test.
vidyasilai
commented
Aug 13, 2026
| slice_reader.read_slice(Interval<usize>{0, this->block_size_}, | ||
| this->slice_storage_, | ||
| this->pin_page_to_job_, | ||
| llfs::LruPriority{kTrieIndexLruPriority})); |
Collaborator
Author
There was a problem hiding this comment.
Need to change the LRU priority here (and on line 62).
tonyastolfi
reviewed
Aug 18, 2026
| std::lower_bound(begin, | ||
| end, | ||
| key_range.lower_bound, | ||
| [](const PackedKeyValueSlotPtr& slot, const KeyView& key) { |
Collaborator
There was a problem hiding this comment.
use KeyOrder for this
vidyasilai
commented
Aug 18, 2026
| return block.status(); | ||
| } | ||
|
|
||
| Slice<const PackedKeyValueSlotPtr> slice = std::get<Slice<const PackedKeyValueSlotPtr>>( |
Collaborator
Author
There was a problem hiding this comment.
Get rid of std::get
tonyastolfi
reviewed
Aug 18, 2026
|
|
||
| llfs::PageId page_id_; | ||
| const PackedBlockedLeafPage* leaf_ = nullptr; | ||
| SmallVec<ConstBuffer, 256> cache_; |
Collaborator
There was a problem hiding this comment.
Maybe increase cache associativity -- e.g., store block i at cache_[i % 256]? The idea being to avoid heap allocation entirely -- we'll need to store i / 256 for each cache slot to make that work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some preliminary code for starting the transition to blocked leaf pages.
The changes in the PR can be grouped into these high-level categories:
artclibrary, removal of ART code within turtle_kv.PackedBlockedLeafPageand related code in thetree/leafdirectory.File with notable changes recently: