Skip to content

Only ship mbt plugin if gRPC is installed #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sameagen-MW wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Only ship mbt plugin if gRPC is installed #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21ddf0c
Only ship mbt plugin if gRPC is installed
sameagen-MW Mar 11, 2026
ff6ca73
Update test method setup to avoid creating build plugin until it's de…
sameagen-MW Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,13 +627,13 @@ install(DIRECTORY ${METRICS_SDK_MATLAB_SOURCES} DESTINATION .)
install(DIRECTORY ${LOGS_SDK_MATLAB_SOURCES} DESTINATION .)
install(DIRECTORY ${COMMON_SDK_MATLAB_SOURCES} DESTINATION .)
install(DIRECTORY ${AUTO_INSTRUMENTATION_MATLAB_SOURCES} DESTINATION .)
install(DIRECTORY ${INSTRUMENTATION_MBT_MATLAB_SOURCES} DESTINATION .)
install(FILES ${EXPORTER_MATLAB_SOURCES} DESTINATION ${OTLP_EXPORTERS_DIR})
if(WITH_OTLP_HTTP)
install(FILES ${OTLP_HTTP_EXPORTER_MATLAB_SOURCES} DESTINATION ${OTLP_EXPORTERS_DIR})
endif()
if(WITH_OTLP_GRPC)
install(FILES ${OTLP_GRPC_EXPORTER_MATLAB_SOURCES} DESTINATION ${OTLP_EXPORTERS_DIR})
install(DIRECTORY ${INSTRUMENTATION_MBT_MATLAB_SOURCES} DESTINATION .)
endif()
if(WITH_OTLP_FILE)
install(FILES ${OTLP_FILE_EXPORTER_MATLAB_SOURCES} DESTINATION ${OTLP_EXPORTERS_DIR})
Expand Down
8 changes: 4 additions & 4 deletions test/tbuildtoolplugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ function setup(testCase)
end

function onlyTestIfgRPCIsInstalled(testCase)
% Do not run if gRPC is not installed
testCase.assumeTrue(logical(exist("opentelemetry.exporters.otlp.OtlpGrpcSpanExporter", "class")), ...
"Otlp gRPC exporter must be installed.");
end

function createBuildRunner(testCase)

% Set up build runner
plugin = matlab.buildtool.plugins.OpenTelemetryPlugin();
testCase.BuildRunner = matlab.buildtool.BuildRunner.withNoPlugins();
testCase.BuildRunner.addPlugin(plugin);
Expand Down Expand Up @@ -474,4 +474,4 @@ function buildToolDoesNotConfigureOTelWhenEnvVariableSet(testCase)
end

error("No span found");
end
end
Loading