Separate CSV column selection into collapsible card#122
Open
rodrigogiraoserrao wants to merge 1 commit intomainfrom
Open
Separate CSV column selection into collapsible card#122rodrigogiraoserrao wants to merge 1 commit intomainfrom
rodrigogiraoserrao wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
#viewercard into a new#column-selectorcard that contains a<details>block with asummarytitled "Column selection" so it is collapsed by default.#viewerand added#column-filter-cardand#column-checkboxesinside the new#column-selectormarkup..column-checkboxes { grid-template-columns: 1fr; }) and added.column-filter-details>summarystyles to indicate the collapsible header.columnSelectorelement and show/hidecolumnSelectortogether withcolumnFilterCardduring CSV load and on parse errors, preserving existing checkbox and "select all" behavior.Testing
git committo record the change and it completed successfully.git status --shortshows a clean working tree after the commit.Codex Task