Changed parsons.block.php to resolve issue #1756#1761
Open
jonaslache wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
I tried to resolve issue #1756 by using
json_encode(stack_string('...'), JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES)instead of juststack_string('...'). This should escape all kinds of quotation marks correctly. I tested this with both the default English language strings and with German language strings that include double quotation marks. Could someone please review this? Please let me know if I have made any mistakes (including any conventions I was not aware of).Thanks and best regards,
Jonas