fix(lore): embed-rebuild refuses when no embedder is wired

[mvanhorn]

Summary

guild lore embed-rebuild previously read meta.embedder_state, saw enabled, then proceeded to wipe lore_vectors and re-encode using embed.NewNullEmbedder() as a placeholder pending QUEST-212. Every encode returned ErrEmbedderDisabled, so coverage stayed at 0% even while lore_health reported the embedder as enabled. Net effect: silent destruction of vectors with no usable rebuild.

This change pulls *EmbedDeps via embedFromDeps(ctx, d) (the same contract appraise_cmd already uses) and refuses to rebuild when the embedder is not wired:

• meta says disabled OR embedder is not wired -> Disabled: true with a reason explaining the wiring gap, and existing vectors are left untouched.
• meta says enabled AND embedder is wired -> the real embedder is used for the encode loop and coverage returns >0%.

The previous "placeholder NullEmbedder pending QUEST-212" block is removed.

Acceptance (matches the issue's acceptance section)

• After embed-rebuild with a wired embedder, vector coverage returns to >0% for projects with active embedders.
• The "embedder disabled" log line and the lore_health "enabled" report no longer contradict: rebuild now refuses up-front when the embedder isn't wired and emits a clear reason instead of silently no-opping.
• Regression test covers the rebuild-then-encode happy path AND the new "embedder not wired" refusal path.

Tests

internal/lore/embed_rebuild_test.go (new):

• TestEmbedRebuild_RefusesWhenEmbedderNotWired - seeds initial vectors through the existing Inscribe path with a fake 384-dim embedder, then calls EmbedRebuildCommand.Handler with stubCommandDeps(nil). Asserts Disabled == true, a non-empty reason, and that the lore_vectors row count is unchanged (no silent wipe).
• TestEmbedRebuild_HappyPathWithWiredEmbedder - seeds entries without vectors (deps == nil during inscribe), then calls the handler with stubCommandDeps(&EmbedDeps{Embedder: fake, ModelID: "test-model"}). Asserts Disabled == false, Encoded > 0, and that the row count after rebuild matches the reported Encoded.

The fake embedder is a small inline type returning a deterministic 384-dim float32 slice; 384 matches the production BGE dimension so the existing Tx2 vector-write path accepts the encode.

go test ./internal/lore/..., go build ./..., go vet ./...: clean.

Files

• internal/lore/embed_rebuild_cmd.go - replace the NullEmbedder placeholder with an embedFromDeps + !ed.Enabled() -> Disabled gate.
• internal/lore/embed_rebuild_test.go (new) - regression tests for both branches.

Closes #88.

[kunallanjewar]

The Reason string here is rendered straight into CLI output via embed_rebuild_cmd.go:108 (🔮 [embed-rebuild] skipped: <reason>), so end users running guild lore embed-rebuild will see "(QUEST-212 pending)" in their terminal. Internal quest IDs are meaningless outside this install and shouldn't leak into user-facing artifacts.

Suggest dropping the parenthetical entirely:

Reason: "embedder runtime is not wired into this surface; embed-rebuild cannot encode and will not wipe existing vectors",

Same information, no internal reference. The QUEST-212 cite still belongs in the package comment / commit body if you want to preserve the traceability for future maintainers.