Fix various issues in content-mathml.js#2184
Open
sylee957 wants to merge 4 commits intomathjax:legacy-v2-developfrom
Open
Fix various issues in content-mathml.js#2184sylee957 wants to merge 4 commits intomathjax:legacy-v2-developfrom
sylee957 wants to merge 4 commits intomathjax:legacy-v2-developfrom
Conversation
97b1f07 to
a28d030
Compare
Author
|
I see mathjax has its own mathml content-to-presentation converter written in javascript, and I have discovered some bugs in #2184 as well. |
Member
|
@christianp, would you be willing to review this PR? |
Contributor
|
@dpvc yes, but I can't commit to a timescale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML code for test examples
I've found a lot of issues in mathml-content-to-presentation converter, regarding parenthesis.
For example, different set operators like
unionandintersectshould be parenthesized correctly according to theapplyscope, but they were ignored.I also see the same problem in the logical operators.
Also, things like nested powers should be parenthesized, or things become undistinguishable.
I've also made the summations and integrals to parenthesis according to the scope, and made summation to have same precedence as addition, and products, integrals as same as the multiplication.
There can be some redundant parenthesis appearing for integrals, but this was the first step for making things correct and consistent.
Also, I have examples of derivatives giving errors or not printed correctly
and also fixed some redundant parenthesis for printing vector operators.