Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1526 +/- ##
===========================================
- Coverage 86.47% 86.47% -0.01%
===========================================
Files 340 340
Lines 86178 86177 -1
Branches 4856 4856
===========================================
- Hits 74520 74519 -1
Misses 11637 11637
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
dir="ltr"attribute to themjx-containerelement so that the math remains left-to-right when used in right-to-left contexts. The SVG output had CSSdirection: ltr, but apparently this by itself isn't enough to override q right-to-left direction. Addingunicode-bidi: isolatewould do it, but apparentlydir="ltr"is to be preferred (see the warning on this MDN page).Resolves issue mathjax/MathJax#3589.