Fix/bussproofs#1525
Open
zorkow wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1525 +/- ##
===========================================
+ Coverage 86.47% 86.71% +0.23%
===========================================
Files 340 340
Lines 86178 86262 +84
Branches 4856 3246 -1610
===========================================
+ Hits 74520 74799 +279
+ Misses 11658 11463 -195 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dpvc
reviewed
Jul 12, 2026
dpvc
left a comment
Member
There was a problem hiding this comment.
One minor request, otherwise looks good. (I admit that I don't know these proof trees, so I can't really check anything myself.)
| * | ||
| * @param {MmlNode} tree The proof tree. | ||
| */ | ||
| private alignProof(tree: MmlNode) { |
Member
There was a problem hiding this comment.
I prefer protected to private for these, so that the item class could be subclassed and the subclass could have access to the method, if needed (e.g., if toMml() is being replaced and needs to call it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Commands for (partially) complete Package
\DisplayProof/\DPwas unsupported: proof commands used outside aprooftree environment now open an implicit proof tree on the parser stack, and
\DisplayProofterminates and displays it — so plain-TeX-style\AxiomC{$A$}\UnaryInfC{$B$}\DisplayProofworks, including inline withinother math, e.g.
X + \AxiomC...\DP + Y. Inside the environment\DisplayProofis redundant and ignored. Forgetting it produces a
"Missing \DisplayProof"error; using it with a malformed tree gives the .sty
s"Proof tree badlyspecified"`.
All remaining abbreviations:
\AX,\UI,\BI,\TI(the\fCentersequent forms),
\QI,\QIC,\QuI,\QuIC,\DP, plus\EnableBpAbbreviationsas an empty operation as abbreviations are alwaysenabled but we don`t want to throw an error.
\dottedLine/\alwaysDottedLineworks now in CHTML and SVG.\doubleLineworks in CHTML, although with less spacing than in LaTeX, but does not work in
SVG. What does not work are combinations as in the actual package (e.g.,
\dottedLine\doubelLineleads to double dotted lines)\insertBetweenHyps: inserts spacing between hyps in the usually emptymtdelement.\kernHyps: adds an mspace to the first premise, sliding the rule premises to the right.\bottomAlignProof / \centerAlignProof / \normalAlignProof: applied at proof
finalization as the root mtable`s align attribute.
Sequent Calculus Fix
Alignment along
\fCenterover multiple sequents was only ever applied to apair of sequent lines, and only when the upper line of the pair was an axiom. So
it worked for a two-line axiom-plus-inference proof but not really anywhere
else.
Consequently, I have replaced
adjustSequentPairwisewithalignSequents,which measures every sequent in the chain once, takes the maximum antecedent
width and maximum succedent width, and pads each line's narrower sides up to
those maxima.