Tests/rewrite array matches#1444
Open
zorkow wants to merge 3 commits intotests/rewrite_remaining_xmlmatchesfrom
Open
Tests/rewrite array matches#1444zorkow wants to merge 3 commits intotests/rewrite_remaining_xmlmatchesfrom
zorkow wants to merge 3 commits intotests/rewrite_remaining_xmlmatchesfrom
Conversation
dpvc
approved these changes
Mar 14, 2026
Member
dpvc
left a comment
dpvc
left a comment
There was a problem hiding this comment.
Looks good. Slight reformatting might be nice, but not crucial.
Comment on lines
+607
to
+608
| await page2mml('<p>$$a=b\\label{eq1}\\tag{1}$$</p><p>Refer to \\eqref{eq1}</p>')). | ||
| toMatchSnapshot(); |
Member
There was a problem hiding this comment.
I'm wondering if the ). from the end of line 607 shouldn't be moved to the beginning of 608.
Similarly for the others. Some I think can be put on a single line, like 177+178.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all occurrences of
toXmlArrayMatchfrom theTagandTextests.This now allows us to get rid of all helper functions related to XML matching, which was done via conversion to JSON. This has the advantage that
xml-jslibrary,xml2jsonconversion entirely.This completes the refactoring of the tests to use snapshots instead of customised XML comparison.