Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1442 +/- ##
==========================================
Coverage 86.49% 86.49%
==========================================
Files 340 340
Lines 86044 86044
Branches 4833 3190 -1643
==========================================
Hits 74425 74425
- Misses 11595 11619 +24
+ Partials 24 0 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpvc
approved these changes
Mar 14, 2026
Member
dpvc
left a comment
There was a problem hiding this comment.
This looks great. Too bad we didn't know about this earlier!
Now that the tests are so much simpler to look at, the extra comment separators between tests probably aren't needed any more. Those were useful to help see where one test stopped and the next started when there were large MathML sections, but since those are no longer in the files, the separators are probably not needed. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all tests that use our custom
toXmlMatchmethod to use Jest's snapshot matching. The only exceptions are the tests inConfigMacros. I need to think a bit about those.Other tests that could probably be done with snapshot matching are those using toXmlArrayMatch.
Both are for a follow-up PR.