Skip to content

Tvs 20260304#1877

Merged
mkerjean merged 4 commits intomath-comp:masterfrom
affeldt-aist:tvs_20260304
Mar 6, 2026
Merged

Tvs 20260304#1877
mkerjean merged 4 commits intomath-comp:masterfrom
affeldt-aist:tvs_20260304

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Mar 4, 2026

Motivation for this change

fyi: @mkerjean

This PR moves the file tvs.v into normedtype_theory in such a way that it only depends num_normedtype.v
and pseudometric_normed_Zmodule (instead of the whole directory).

In the process:

  • some structures (that are actually joins) needed to be moved out of tvs.v and
    placed earlier in the file hierarchy (it looks like a good change)
  • some local lemmas were turned into Let's (this was an oversight)
  • two longish proofs could be shortened (standard_{add,scale}_continuous)
  • comments that were suggesting proof sharing have been updated
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.16.0 milestone Mar 4, 2026
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Mar 4, 2026
@affeldt-aist affeldt-aist marked this pull request as ready for review March 6, 2026 02:18
Copy link
Collaborator

@mkerjean mkerjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifying code and allowing for further simpler proofs in tvs.v

@mkerjean mkerjean merged commit e63da36 into math-comp:master Mar 6, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

renaming/refactoring 🔧 This is about a renaming or refactoring in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants