Skip to content

derive_mx#1829

Open
affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
affeldt-aist:robot_rocq_20260122
Open

derive_mx#1829
affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
affeldt-aist:robot_rocq_20260122

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jan 21, 2026

Motivation for this change

two lemmas from robot-rocq that are also useful for ode @CohenCyril

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.16.0 milestone Feb 24, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Feb 24, 2026
@affeldt-aist
Copy link
Member Author

affeldt-aist commented Feb 27, 2026

@holgerthies @yosakaon @IshiguroYoshihiro if one of you has a minute, could you take a quick look?

Since theses lemmas have already by tested by others and proved useful elsewhere, I think that it is reasonable to merge them if CI is green and if there are no objections.

Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably also are instances of is_diff and is_derive to add, but one should make sure they are not looping.

@affeldt-aist
Copy link
Member Author

There probably also are instances of is_diff and is_derive to add, but one should make sure they are not looping.

Indeed, I also thought (but was quick to forget) that we do not honor the intended API that ought to provide automation. I started mimicking what was done for other constructions but I am starting being confused. Can you take a quick look at affeldt-aist@30c013a and open my eyes?

@affeldt-aist affeldt-aist mentioned this pull request Mar 2, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants