Check for many contributions to warn of potential OOM and clarify use…#1119
Draft
bfoley12 wants to merge 2 commits into
Draft
Check for many contributions to warn of potential OOM and clarify use…#1119bfoley12 wants to merge 2 commits into
bfoley12 wants to merge 2 commits into
Conversation
… of ignore_dupes in docstring of submit_contributions
tsmathis
reviewed
Jul 7, 2026
| skip_dupe_check (bool): skip duplicate check for contribution identifiers | ||
|
|
||
| Returns: | ||
| None |
Collaborator
There was a problem hiding this comment.
any reason to remove the collection type check?
I don't see any other guards around
Author
There was a problem hiding this comment.
Method is defined to only take list[dict]:
def submit_contributions(
self,
contributions: list[dict],
...
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Leo found that our
submit_contributionsclient method needed to be clearer in documentation.Changes