Skip to content

Misc small changes#1070

Merged
esoteric-ephemera merged 2 commits intomainfrom
synth
Mar 20, 2026
Merged

Misc small changes#1070
esoteric-ephemera merged 2 commits intomainfrom
synth

Conversation

@esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Mar 20, 2026

Scope of PR has changed, leaving this here for future documentation:

There are two synthesis schemas in emmet.core.synthesis:

  • SynthesisRecipe (curent change): actual data schema
  • SynthesisSearchResultModel (previous): data schema + Atlas search metadata

Since the Atlas search fields are pruned by emmet-api before returning to the user, we don't need to pass these additional, unused fields to the user
The Atlas search fields are only injected if keyword search is used, and they are still returned to the user. So the appropriate schema for this endpoint would be SynthesisSearchResultModel generally

See emmet-core updates here for more info on the Atlas search related fields

@esoteric-ephemera esoteric-ephemera changed the title Update synthesis schema Misc small changes Mar 20, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.82%. Comparing base (bd4edbb) to head (f898181).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   86.80%   86.82%   +0.02%     
==========================================
  Files          47       47              
  Lines        2682     2680       -2     
==========================================
- Hits         2328     2327       -1     
+ Misses        354      353       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@esoteric-ephemera esoteric-ephemera merged commit a08a927 into main Mar 20, 2026
3 checks passed
@esoteric-ephemera esoteric-ephemera deleted the synth branch March 20, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants