Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
+ Coverage 86.80% 86.82% +0.02%
==========================================
Files 47 47
Lines 2682 2680 -2
==========================================
- Hits 2328 2327 -1
+ Misses 354 353 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of PR has changed, leaving this here for future documentation:
There are two synthesis schemas in
emmet.core.synthesis:Since the Atlas search fields are pruned by emmet-api before returning to the user, we don't need to pass these additional, unused fields to the userThe Atlas search fields are only injected if keyword search is used, and they are still returned to the user. So the appropriate schema for this endpoint would be
SynthesisSearchResultModelgenerallySee emmet-core updates here for more info on the Atlas search related fields