Skip to content

Updated to barebonesV1.3 (stable), added CDN delivered header …#16

Merged
eimrek merged 6 commits intodevelopfrom
migration
Jun 2, 2025
Merged

Updated to barebonesV1.3 (stable), added CDN delivered header …#16
eimrek merged 6 commits intodevelopfrom
migration

Conversation

@Bud-Macaulay
Copy link
Copy Markdown
Contributor

I believe this tool is live on:
https://tools.materialscloud.org/seekpath/
which has no header implemented and is rendered as an iFrame on:
https://www.materialscloud.org/work/tools/seekpath

I have updated it for the migration (the best i easily can) and it builds successfully...
There is a Docker compatibility issue between barebones v1.4 and this tool.
a numpy update means this tool is stuck on py3.7, while bb v1.4 uses py3.10...

So for now;

  1. Updated to use the barebones v1.3 (which fetches the header on tools landing page)
  2. Add breadcrumbing to this tool.
  3. Get the header through CDN injection [see]: (github.com/materialscloud-org/mc-header)

If I get time after the migration;

  1. I'll look to see if we can migrate this codebase to a newer py release within MC.
  2. See if there is a nicer way to build tools without relying on this clunky barebones.
  3. Look at migrating 'all' of the site to use mc-header (after addition of @media tracking) so that it says in cache and is not rebuilt/differ from page to page.

@Bud-Macaulay Bud-Macaulay requested a review from eimrek June 2, 2025 13:06
Copy link
Copy Markdown
Member

@eimrek eimrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bud-Macaulay. The tests are failing due to python 3.6 not being available on github actions, although it's needed for this legacy app. It's working locally, so i'm merging for now, but in the future this project should be migrated to a modern python version.

@eimrek eimrek marked this pull request as ready for review June 2, 2025 15:14
@eimrek eimrek merged commit a6ec6b0 into develop Jun 2, 2025
0 of 4 checks passed
@eimrek eimrek deleted the migration branch June 2, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants