Conversation
eimrek
approved these changes
Jun 2, 2025
Member
eimrek
left a comment
There was a problem hiding this comment.
Thanks @Bud-Macaulay. The tests are failing due to python 3.6 not being available on github actions, although it's needed for this legacy app. It's working locally, so i'm merging for now, but in the future this project should be migrated to a modern python version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this tool is live on:
https://tools.materialscloud.org/seekpath/
which has no header implemented and is rendered as an iFrame on:
https://www.materialscloud.org/work/tools/seekpath
I have updated it for the migration (the best i easily can) and it builds successfully...
There is a Docker compatibility issue between barebones v1.4 and this tool.
a numpy update means this tool is stuck on py3.7, while bb v1.4 uses py3.10...
So for now;
If I get time after the migration;