Skip to content

Fixes offsets for s1 and s2#658

Merged
wuda-io merged 1 commit into
materializecss:v2-devfrom
svalo:657-fix-offset-s1-offset-s2
Apr 21, 2026
Merged

Fixes offsets for s1 and s2#658
wuda-io merged 1 commit into
materializecss:v2-devfrom
svalo:657-fix-offset-s1-offset-s2

Conversation

@svalo
Copy link
Copy Markdown

@svalo svalo commented Apr 21, 2026

Offsets for 's' were not consistent with 'l' and 'm' causing unexpected behavior.

Fixes: #657

Proposed changes

Changes grid column start for s1 and s2 to make it consistent with m1, m2 and l1, l2

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Offsets for 's' were not consistent with 'l' and 'm' causing unexpected behaviour. Now they all work the same

Fixes: materializecss#657
@svalo svalo closed this Apr 21, 2026
@svalo svalo reopened this Apr 21, 2026
Copy link
Copy Markdown
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io merged commit ec1c1ef into materializecss:v2-dev Apr 21, 2026
1 check passed
@svalo svalo deleted the 657-fix-offset-s1-offset-s2 branch April 21, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants