Skip to content

fix(labs): align outline width tokens to size mixins for button #6034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 21, 2026
+12 −22
Merged

fix(labs): align outline width tokens to size mixins for button #6034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions labs/gb/components/button/_button-tokens.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,6 @@
--icon-color: var(--md-sys-color-on-surface-variant);
--label-text-color: var(--md-sys-color-on-surface-variant);
--outline-color: var(--md-sys-color-outline-variant);
--outline-width: 1px;
}

@mixin outlined-lg {
--outline-width: 2px;
}

@mixin outlined-xl {
--outline-width: 3px;
}

@mixin outlined-selected {
Expand All @@ -99,31 +90,34 @@
}

@mixin text {
--label-text-color: var(--md-sys-color-primary);
--icon-color: var(--md-sys-color-primary);
--label-text-color: var(--md-sys-color-primary);
--state-layer-color: var(--md-sys-color-primary);
}

@mixin xs {
--container-height: 32px;
--leading-space: 12px;
--outline-width: 1px;
--trailing-space: 12px;
}

@mixin sm {
--container-height: 40px;
--leading-space: 16px;
--outline-width: 1px;
--trailing-space: 16px;
}

@mixin md {
--container-height: 56px;
--leading-space: 24px;
--trailing-space: 24px;
--icon-size: 24px;
--label-text: var(--md-sys-typescale-title-md);
--label-text-axes: var(--md-sys-typescale-title-md-axes);
--label-text-tracking: var(--md-sys-typescale-title-md-tracking);
--leading-space: 24px;
--outline-width: 1px;
--trailing-space: 24px;
}

@mixin md-selected {
Expand All @@ -134,11 +128,12 @@
--container-height: 96px;
--icon-label-space: 12px;
--icon-size: 32px;
--leading-space: 48px;
--trailing-space: 48px;
--label-text: var(--md-sys-typescale-headline-sm);
--label-text-axes: var(--md-sys-typescale-headline-sm-axes);
--label-text-tracking: var(--md-sys-typescale-headline-sm-tracking);
--leading-space: 48px;
--outline-width: 2px;
--trailing-space: 48px;
}

@mixin lg-selected {
Expand All @@ -149,11 +144,12 @@
--container-height: 136px;
--icon-label-space: 16px;
--icon-size: 40px;
--leading-space: 64px;
--trailing-space: 64px;
--label-text: var(--md-sys-typescale-headline-lg);
--label-text-axes: var(--md-sys-typescale-headline-lg-axes);
--label-text-tracking: var(--md-sys-typescale-headline-lg-tracking);
--leading-space: 64px;
--outline-width: 3px;
--trailing-space: 64px;
}

@mixin xl-selected {
Expand Down
6 changes: 0 additions & 6 deletions labs/gb/components/button/button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@
}
&.btn-outlined {
@include button-tokens.outlined;
&:where(.btn-lg) {
@include button-tokens.outlined-lg;
}
&:where(.btn-xl) {
@include button-tokens.outlined-xl;
}
&:where(.btn-selected, [aria-pressed='true']) {
@include button-tokens.outlined-selected;
}
Expand Down
Loading