Skip to content

[TimePicker] Inherit M3 timepicker button style from M3 button style #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pubiqq wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TimePicker] Inherit M3 timepicker button style from M3 button style #5026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions lib/java/com/google/android/material/timepicker/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,13 @@
<item name="clockNumberTextColor">@color/material_timepicker_clock_text_color</item>
</style>

<style name="Widget.Material3.MaterialTimePicker.Button" parent="Widget.MaterialComponents.TimePicker.Button">
Copy link
Contributor

@drchen drchen Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intended and what's the reason behind this. I'll let someone else to check.

<style name="Widget.Material3.MaterialTimePicker.Button" parent="Widget.Material3.Button.OutlinedButton">
<item name="android:layout_height">48dp</item>
<item name="android:padding">0dp</item>
<item name="android:insetTop">0dp</item>
<item name="android:insetBottom">0dp</item>
<item name="android:textSize">16sp</item>
<item name="android:textAlignment">center</item>
<item name="android:textAppearance">@macro/m3_comp_time_picker_period_selector_label_text_type</item>
<item name="android:textColor">@color/m3_timepicker_button_text_color</item>
<item name="backgroundTint">@color/m3_timepicker_button_background_color</item>
Expand All @@ -137,7 +143,15 @@
<item name="shapeAppearance">@macro/m3_comp_time_picker_period_selector_container_shape</item>
<item name="shapeAppearanceOverlay">@null</item>
<!-- Apply theme overlay to disable elevation overlays so we can get a purely colorSurface chip. -->
<item name="materialThemeOverlay">@style/ThemeOverlay.MaterialComponents.TimePicker.Display</item>
<item name="materialThemeOverlay">@style/ThemeOverlay.Material3.TimePicker.Button</item>
</style>

<!-- Disabling elevation overlays because when chip's default
background/surface composite are combined with elevation overlays in a
highly elevated dialog, the resulting color becomes too light and causes
contrast issues -->
<style name="ThemeOverlay.Material3.TimePicker.Button" parent="ThemeOverlay.Material3.Button.TextButton">
<item name="elevationOverlayEnabled">false</item>
</style>

<style name="Widget.Material3.MaterialTimePicker" parent="Widget.MaterialComponents.TimePicker">
Expand Down