Skip to content

Comments

Solution#3278

Open
somogyikrisztina01 wants to merge 2 commits intomate-academy:masterfrom
somogyikrisztina01:develop
Open

Solution#3278
somogyikrisztina01 wants to merge 2 commits intomate-academy:masterfrom
somogyikrisztina01:develop

Conversation

@somogyikrisztina01
Copy link

Solution

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution as an educational override so you can continue progressing while you practice these concepts. You correctly defined all 8 required variables of different data types and created the sorted_variables dictionary with the two keys "mutable" and "immutable", which matches the task structure. However, in app/main.py the values are currently misclassified: on the line where you assign the "mutable" list, you’ve placed immutable values (lucky_number, pi, one_is_a_prime_number, name, profile_info), and on the line where you assign the "immutable" list, you’ve placed mutable values (my_favourite_films, marks, collection_of_coins) — this goes against the requirement that mutable objects (list, dict, set) must be under "mutable" and immutable ones (int, float, bool, str, tuple) under "immutable" [CHECKLIST ITEM #2, #3]. To fix this, simply swap the groupings so that sorted_variables["mutable"] contains the list, dict, and set variables, and sorted_variables["immutable"] contains the int, float, bool, string, and tuple variables (the variables themselves, not their names as strings). Everything else about your structure looks good, and once you correct the classification, your solution will fully match the task’s intent. Nice work getting the overall setup right—fine-tuning the mutable vs. immutable distinction is a valuable step in deepening your understanding of Python’s data types.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

app/main.py Outdated

# write your code here
sorted_variables = {
"mutable": [lucky_number, pi, one_is_a_prime_number, name, profile_info],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list assigned to the "mutable" key contains immutable types (int, float, bool, str, tuple). This violates checklist item #2. Move lucky_number, pi, one_is_a_prime_number, name, and profile_info into the "immutable" list.

app/main.py Outdated
# write your code here
sorted_variables = {
"mutable": [lucky_number, pi, one_is_a_prime_number, name, profile_info],
"immutable": [my_favourite_films, marks, collection_of_coins]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list assigned to the "immutable" key contains mutable types (list, dict, set). This violates checklist item #3. Move my_favourite_films, marks, and collection_of_coins into the "mutable" list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants