Fix Mantis #47085: improve Tag example contrast#13
Open
marvimarv wants to merge 1 commit intorelease_10from
Open
Fix Mantis #47085: improve Tag example contrast#13marvimarv wants to merge 1 commit intorelease_10from
marvimarv wants to merge 1 commit intorelease_10from
Conversation
The Kitchen Sink Tag example used a red/green combination below WCAG AA for normal text. This updates the fixed foreground color to a darker red so the sample demonstrates an accessible contrast ratio. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Button/Tagexample so the red-on-green sample meets WCAG 2.1 AA contrast for normal text.components/ILIAS/UI/src/examples/Button/Tag/base.phpis changed.Test plan
goto.php/stys/21/ButtonTagTag/default/delossimple tagnow reaches at least4.5:1