Removed Duplication in ObjectiveClass#6
Open
trimmurrti wants to merge 7 commits intomarmelroy:masterfrom
Open
Conversation
…ntime for better deduplication
…safemutablepointer, used pure to convert from implicit optional, improved style
Author
|
Update in case you wonder, hacktoberfest accepts pending requests. The next step is the pull-request rejection. |
iThinker
approved these changes
Oct 12, 2017
Author
|
@marmelroy Please, note the build failure because of code signing failure. Won't be able to fix it on my end, as I double checked and I didn't change any certificates and such. |
1 similar comment
Author
|
@marmelroy Please, note the build failure because of code signing failure. Won't be able to fix it on my end, as I double checked and I didn't change any certificates and such. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was created for the sole purpose of showing my students, that they should think on their own instead of following thought leaders and popular bloggers, as they, while being popular, still are human and sometimes don't write that great or just plain bad and dirty code. The code prior to the pull request is a perfect example of such code because of the excess amount of duplication.
The secondary aim of refactoring was to show my students, how to use some unobvious ways of handling functions in swift, when using unsafe force-cast related code.
I've created this pull request just to check, how hacktoberfest (I really want that t-shirt, yay) reacts to rejected or ignored pull requests, as original maintainer, from what it looks, ignores pull requests from other users.
P.S. I doubt the maintainer would merge the pull request, so I didn't update to Swift 4. If accept happens for some weird reason, I would refactor it to swift 4 with pleasure.