Skip to content

Support for Swift 4.2#53

Open
algonrey wants to merge 4 commits intomarmelroy:masterfrom
algonrey:master
Open

Support for Swift 4.2#53
algonrey wants to merge 4 commits intomarmelroy:masterfrom
algonrey:master

Conversation

@algonrey
Copy link
Copy Markdown

No description provided.

@RedDragonJ
Copy link
Copy Markdown

Just wonder who actually maintain the CI system? I think it needs to update the build for xcode 10 in order to pass the check. I'm also waiting for the new Swift 4.2 support. Thanks.

@algonrey
Copy link
Copy Markdown
Author

Just wonder who actually maintain the CI system? I think it needs to update the build for xcode 10 in order to pass the check. I'm also waiting for the new Swift 4.2 support. Thanks.

Hi @RedDragonJ, meanwhile the repo is not merged of fixed, you can use my fork to install it with cocoapods:
pod 'FileBrowser', :git => 'https://github.com/Algonrey/FileBrowser.git'

Regards!

Copy link
Copy Markdown

@RedDragonJ RedDragonJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test those changes?

@algonrey
Copy link
Copy Markdown
Author

Yep, i did a little test today and it seems to work ok

Copy link
Copy Markdown

@RedDragonJ RedDragonJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think we should remove self keyword in the future unless absolutely necessary to enforce best Swift practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants