[TypeScript] Add missing ra.validation.unique to TranslationMessages - #11337
Open
bicstone wants to merge 1 commit into
Open
[TypeScript] Add missing ra.validation.unique to TranslationMessages#11337bicstone wants to merge 1 commit into
bicstone wants to merge 1 commit into
Conversation
ra-language-english has shipped `ra.validation.unique` since the unique validator was introduced, but the interface never declared it. Because `ra.validation` carries an index signature for custom messages, the omission compiles silently, so a translation package typed as TranslationMessages can drop the key without any error and let Polyglot render the raw key name to end users. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014c5Smg7wiDnqQPS6HeWrMK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TranslationMessagesdoes not declarera.validation.unique, even though react-admin emits that message key andra-language-englishships it.useUniquereturns{ message: 'ra.validation.unique' }(packages/ra-core/src/form/validation/useUnique.ts#L82)ra-language-englishandra-language-frenchboth define itTranslationMessages['ra']['validation']does notSolution
Declare
unique: stringinra.validation, in the same position as inra-language-english.How To Test
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.