-
Notifications
You must be signed in to change notification settings - Fork 168
Add the possibility to wrap the stack view within the superview's layout margins #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexbredy
wants to merge
6
commits into
marlimox:master
Choose a base branch
from
alexbredy:preserve.superview.layout.margins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
269da9b
Add the possibility to wrap the stack view within the superview's lay…
alexbredy 6ee8725
Add an example related to the superview layout margins
alexbredy d0dfcda
format comment
alexbredy e7d0ade
edit copy of mainvc
alexbredy ac7f07f
Fix typo in AloeStackView.swift
alexbredy c6e85f0
Merge branch 'master' into preserve.superview.layout.margins
alexbredy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
Example/AloeStackViewExample/ViewControllers/PreserveLayoutMarginsViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Created by Alexander Bredy on 01/02/2019. | ||
| // Copyright © 2019 Airbnb, Inc. All rights reserved. | ||
|
|
||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
|
|
||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import AloeStackView | ||
| import UIKit | ||
|
|
||
| public class PreserveLayoutMarginsViewController: AloeStackViewController { | ||
|
|
||
| // MARK: Public | ||
|
|
||
| public override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| setUpSelf() | ||
| setUpStackView() | ||
| setUpRows() | ||
| } | ||
|
|
||
| // MARK: Private | ||
|
|
||
| private func setUpSelf() { | ||
| title = "Preserve superview layout margins" | ||
| } | ||
|
|
||
| private func setUpStackView() { | ||
| // Setting this property to true will constrain the stack view content within the layout margins of the superview | ||
| stackView.preservesSuperviewLayoutMargins = true | ||
|
|
||
| // Setting separator and row insets on this screen will add additional margins to the ones set by the | ||
| // superview. | ||
| stackView.separatorInset = .zero | ||
| stackView.rowInset = .zero | ||
| } | ||
|
|
||
| private func setUpRows() { | ||
| setUpDescriptionRow() | ||
| setUpAnotherRow() | ||
| } | ||
|
|
||
| private func setUpDescriptionRow() { | ||
| let label = UILabel() | ||
| label.font = UIFont.preferredFont(forTextStyle: .body) | ||
| label.numberOfLines = 0 | ||
| label.text = "The margins of the AloeStackView in this screen include the ones from the superview layout margins." | ||
| stackView.addRow(label) | ||
| } | ||
|
|
||
| private func setUpAnotherRow() { | ||
| let label = UILabel() | ||
| label.font = UIFont.preferredFont(forTextStyle: .body) | ||
| label.numberOfLines = 0 | ||
| label.text = "Check out this ViewController on both iPhone and iPad to see the margins difference!" | ||
| stackView.addRow(label) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.