fix(database-mysql): Added missing QueryBuilderFactoryInterface implementation#7
Merged
markshust merged 2 commits intomarko-php:developfrom Apr 5, 2026
Conversation
github-actions
bot
added
bug
…import Add unit tests for MySqlQueryBuilderFactory (creation, independence, interface compliance) and a module binding test for the new QueryBuilderFactoryInterface entry. Remove unnecessary self-namespace import in the factory class. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
markshust
force-pushed
the
fix/add-factory-implementation
branch
from
42a9db3 to
76b0395
Compare
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing QueryBuilderFactoryInterface implementation to the marko/database-mysql package.
The Repository base class depends on QueryBuilderFactoryInterface, even though it says it's optional (vendor/marko/database/src/Repository/Repository.php:50). While this dependency is marked as optional in the constructor, it becomes required when calling query(). Without this implementation, repositories extending Repository and using custom queries throw NoDriverException::noDriverInstalled when the DI container attempts to bind the dependency.
This PR adds:
Related commit where this was done for pgSQL, but not MySQL: 2e530f02
Additional changes (maintainer)
developMySqlQueryBuilderFactory(creation, instance independence, interface compliance)QueryBuilderFactoryInterfaceentry inModuleBindingsTest.phpuse Marko\Database\MySql\Query\MySqlQueryBuilder) from the factory classType of Change
Checklist
./vendor/bin/pest --parallel)./vendor/bin/phpcs)