fix: handle sliced Buffer byte ranges in ECDH/DH native bridge#973
Open
tp26610 wants to merge 8 commits intomargelo:mainfrom
Open
fix: handle sliced Buffer byte ranges in ECDH/DH native bridge#973tp26610 wants to merge 8 commits intomargelo:mainfrom
tp26610 wants to merge 8 commits intomargelo:mainfrom
Conversation
…-native-vector-icons/fonts.gradle'
This reverts commit 2bf497d.
…les/react-native-vector-icons/fonts.gradle'" This reverts commit afdaeac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes ECDH/Diffie-Hellman behavior when input keys are provided as Buffer views (non-zero
byteOffset), which previously could pass an incorrect memory range to the native bridge.What changed
computeSecret()using a sliced public-key Buffer in the RN example test suite.[byteOffset, byteOffset + byteLength)range before passing to native.Why
Node-compatible crypto APIs should treat Buffer views correctly.
Without exact-range conversion, sliced Buffers may expose extra bytes from the underlying ArrayBuffer and cause invalid key parsing or mismatched shared secrets.
Test plan
computeSecretwith sliced public key Buffer