Upgrade to .NET 8, async RabbitMQ, and modern C# features#3
Open
AngeloDotNet wants to merge 5 commits intomarcominerva:masterfrom
Open
Upgrade to .NET 8, async RabbitMQ, and modern C# features#3AngeloDotNet wants to merge 5 commits intomarcominerva:masterfrom
AngeloDotNet wants to merge 5 commits intomarcominerva:masterfrom
Conversation
Upgraded all projects to .NET 8 and updated NuGet packages for compatibility. Refactored RabbitMQ integration to use new async APIs and modernized consumers. Adopted C# 12 primary constructors in key classes and controllers, improved code style via enhanced .editorconfig, and ensured proper cancellation support. Cleaned up codebase for clarity, maintainability, and alignment with current C#/.NET best practices.
marcominerva
requested changes
Dec 18, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marcominerva
requested changes
Dec 18, 2025
Refactored MessageManager to use asynchronous initialization and disposal. Introduced a static CreateAsync factory method for async setup of RabbitMQ connections, channels, and queues. Replaced IDisposable with IAsyncDisposable and implemented DisposeAsync to properly await resource cleanup. All setup operations now use async/await for improved resource management and modern .NET practices.
Author
|
@marcominerva I modified it as requested using IAsyncDisposable. Changes included in the PR commit f83036a |
Refactored the CreateAsync method to set the Connection property of MessageManager directly in the object initializer, removing the redundant assignment line. This improves code conciseness and readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @marcominerva with this PR I have:
Next step in the next few days is the migration of the solution to .NET 10