Skip to content

fix: correct types declarations align to source code#300

Open
JounQin wants to merge 1 commit intomarcj:masterfrom
JounQin:fix/types
Open

fix: correct types declarations align to source code#300
JounQin wants to merge 1 commit intomarcj:masterfrom
JounQin:fix/types

Conversation

@JounQin
Copy link
Copy Markdown

@JounQin JounQin commented Jul 21, 2020

The following codes are actually incorrect but current types won't complain about it.

import { ElementQueries } from 'css-element-queries/src/ElementQueries'
import { ResizeSensor } from 'css-element-queries/src/ResizeSensor'

They should be like the following:

// by default
import * as ElementQueries from 'css-element-queries/src/ElementQueries'
import * as ResizeSensor from 'css-element-queries/src/ResizeSensor'

// or with `esModuleInterop: true` enabled
import ElementQueries from 'css-element-queries/src/ElementQueries'
import ResizeSensor from 'css-element-queries/src/ResizeSensor'

@ghost
Copy link
Copy Markdown

ghost commented Feb 6, 2022

a nice feature to be validated I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant