Locate/Result and Export #242
Open
susilnem wants to merge 2 commits intoproject/locate-feature-workflowfrom
Open
Locate/Result and Export #242susilnem wants to merge 2 commits intoproject/locate-feature-workflowfrom
susilnem wants to merge 2 commits intoproject/locate-feature-workflowfrom
Conversation
- add new field task_partition_index - changes on temp to result table for locate project results
susilnem
force-pushed
the
feature/locate-result-export
branch
from
abc0857 to
c9aae1d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## project/locate-feature-workflow #242 +/- ##
===================================================================
- Coverage 87.53% 87.52% -0.02%
===================================================================
Files 211 211
Lines 12744 12756 +12
Branches 1078 1080 +2
===================================================================
+ Hits 11156 11165 +9
- Misses 1188 1191 +3
Partials 400 400 ☔ View full report in Codecov by Sentry. |
susilnem
commented
Mar 25, 2026
tnagorra
reviewed
Mar 31, 2026
| groupby_cols = ["project_id", "group_id", "task_id", "result"] | ||
| index_cols = ["task_id"] | ||
|
|
||
| if "task_partition_index" in results_df.columns and project.project_type_enum == ProjectTypeEnum.LOCATE: |
Collaborator
There was a problem hiding this comment.
Let's add a NOTE why we are doing this.
| case Project.Type.LOCATE: | ||
| # TODO(susilnem): We might need to adjust this number later. | ||
| group_size = 120 | ||
| group_size = 25 |
Collaborator
There was a problem hiding this comment.
We also need to add a assert_never here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
Depends on
Changes
This PR doesn't introduce any:
printThis PR contains valid: