Add GFM alerts and front-matter support - #37
Conversation
Add regression coverage that exercises SVG set and animate URL filtering and fails against the vulnerable dependency release. Agent-Signature: codex-gpt-5.2-high on behalf of Matt Wilkie
Agent-Signature: codex-unknown-model- on behalf of Matt Wilkie
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summary (commit 51465f5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 51465f5)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by step-3.7-flash · Input: 59.7K · Output: 16.3K · Cached: 221.2K |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51465f5c21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address PR #37 review findings: - Strip YAML front matter before parsing instead of enabling ENABLE_YAML_STYLE_METADATA_BLOCKS: pulldown-cmark 0.13 recognizes metadata blocks anywhere at indent 0, silently swallowing mid-document text framed by `---` lines. The hand-rolled yaml_front_matter splitter is now the single source of truth for both hiding the block and title derivation. - Make the splitter conservative and GitHub-like: front matter only at the very start of the document, closing `---`/`...` on its own line (trailing spaces ok, tabs not), block non-empty with a non-blank first line, so `---\n\ntitle: fake\n---` can no longer spoof the page title. - Keep GFM alerts styled with JavaScript disabled: add plain :root light-palette defaults and a prefers-color-scheme dark media query alongside the existing data-theme theme-toggle overrides. - Add regression tests for mid-document `---` blocks and blank-first-line pseudo front matter; extend the alert CSS test. - cfg-gate unix-only Duration/Instant test imports so `cargo clippy --all-targets -- -D warnings` also passes on Windows. - Record GFM alerts and YAML front matter in the changelog. Agent-Signature: claude-code-fable-5 on behalf of maphew Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvsZX2KKgN6BrCCrNrJ5BW
|
Pushed 9b7f5e2 addressing the review findings:
Also cfg-gated the unix-only claude-code-fable-5 on behalf of maphew |
maphew
left a comment
maphew
left a comment
There was a problem hiding this comment.
Reviewed the current head as the second layer of the stack, including commit 9b7f5e2 against the now-merged ammonia upgrade.
No remaining blocking concerns found. The earlier title-spoof/content-loss finding is substantively fixed by conservative start-of-document front-matter splitting and body stripping before Markdown parsing, with regression coverage. The current head also adds no-JavaScript alert palette defaults, Windows-safe test imports, and changelog entries. The PR has been retargeted to main; fresh CI is running for that recalculated base.
codex-gpt-5.6-sol-medium on behalf of maphew
Resolve the changelog release-boundary conflict by keeping the new alert and front-matter entries under Unreleased while preserving the 0.6.1 notes from main. Agent-Signature: codex-gpt-5.6-sol-medium on behalf of maphew
Integrate the current #37 head, including its merge from main, so this branch is compatible with the retargeted stack. Agent-Signature: codex-gpt-5.6-sol-high on behalf of matt wilkie
2 participants
Summary