update AWS SDK from v2 to v3; npm audit fix#938
Merged
cclauss merged 3 commits intomapbox:masterfrom Feb 20, 2026
Merged
Conversation
mdaniels5757
force-pushed
the
update-aws-sdk
branch
from
4f292e0 to
6e88156
Compare
Contributor
Author
|
Fixed lint. |
mdaniels5757
force-pushed
the
update-aws-sdk
branch
from
6e88156 to
394d7d9
Compare
Contributor
Author
|
Re-ran
|
cclauss
reviewed
Feb 20, 2026
| "nock": "^13.5.4", | ||
| "node-addon-api": "^8.1.0", | ||
| "nyc": "^17.0.0", | ||
| "rimraf": "^6.1.2", |
Collaborator
There was a problem hiding this comment.
https://www.npmjs.com/package/rimraf
[!CAUTION]
Please Be Safe, this tool deletes and moves stuff, by design
It is your responsibility as a user to never pass untrusted user input to this module, or your system can be destroyed or compromised.
Contributor
Author
There was a problem hiding this comment.
This package is not new to this project; it has been used in tests since at least 2015.
The tests fail without it. Despite that, it was not actually installed when developers ran npm install in this repository. I can remove it, if you like, but then of course running npm ci; npm run test will fail (as it already does).
Collaborator
There was a problem hiding this comment.
My comment was just a caution, not a request for a change.
Also, let's get the tests to pass like:
Note that eslint-config-mapbox has to be pinned due to mapbox/eslint-plugin-mapbox#3.
mdaniels5757
force-pushed
the
update-aws-sdk
branch
from
394d7d9 to
6d5a012
Compare
cclauss
approved these changes
Feb 20, 2026
cclauss
added a commit
to cclauss/node-pre-gyp
that referenced
this pull request
Feb 21, 2026
* update AWS SDK from v2 to v3 * npm audit fix Note that eslint-config-mapbox has to be pinned due to mapbox/eslint-plugin-mapbox#3. * Allow npm audit to fail without breaking CI --------- Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I've run
npm run test, but haven't done any additional testing. (I don't even use this tool directly, it's just a transitive dependency, that I noticed due to #932.)