Skip to content

Migrate NPM publishing to use trusted publishing instead of classic tokens #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acalcutt wants to merge 5 commits into
base: master
Choose a base branch
from
+12 −15
Open

Migrate NPM publishing to use trusted publishing instead of classic tokens #929

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3caa97a
migrate workflow to use npm trusted publishing
acalcutt Dec 12, 2025
27aa09b
read package name from pavkage.json, use node 24
acalcutt Dec 12, 2025
176ca8a
put back contents: write to fix git release publish
acalcutt Dec 12, 2025
88050a6
Update release.yml
acalcutt Dec 12, 2025
8c1e4a4
use only global permissions
acalcutt Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: release

permissions:
id-token: write # Required for NPM trusted publishing
contents: write
Comment thread
acalcutt marked this conversation as resolved.

on:
push:
branches: [master]
Expand Down Expand Up @@ -36,8 +40,6 @@ jobs:
needs: release-check
if: ${{ needs.release-check.outputs.published == 'false' }}
runs-on: ubuntu-latest
permissions:
contents: write
defaults:
run:
shell: bash
Expand All @@ -48,6 +50,7 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: 22
Comment thread
lukekarrys marked this conversation as resolved.
Outdated
registry-url: 'https://registry.npmjs.org'

- run: npm ci

Expand Down Expand Up @@ -90,16 +93,8 @@ jobs:

- name: Publish to NPM (release)
if: ${{ steps.prepare_release.outputs.prerelease == 'false' }}
run: |
npm config set //registry.npmjs.org/:_authToken "${NPM_TOKEN}"
npm publish --access public
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npm publish --access public

- name: Publish to NPM (prerelease)
if: ${{ steps.prepare_release.outputs.prerelease == 'true' }}
run: |
npm config set //registry.npmjs.org/:_authToken "${NPM_TOKEN}"
npm publish --tag next --access public
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npm publish --tag next --access public
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"author": "Dane Springmeyer <dane@mapbox.com>",
"repository": {
"type": "git",
"url": "git://github.com/mapbox/node-pre-gyp.git"
"url": "https://github.com/mapbox/node-pre-gyp"
},
"bin": "./bin/node-pre-gyp",
"main": "./lib/node-pre-gyp.js",
Expand Down