Skip to content

Avoid tweakpane imports in public declarations#13682

Open
2lll5 wants to merge 1 commit into
mapbox:mainfrom
2lll5:fix-devtools-declaration-tweakpane
Open

Avoid tweakpane imports in public declarations#13682
2lll5 wants to merge 1 commit into
mapbox:mainfrom
2lll5:fix-devtools-declaration-tweakpane

Conversation

@2lll5

@2lll5 2lll5 commented Jun 11, 2026

Copy link
Copy Markdown

Fixes #13680.

This keeps the devtools runtime dependency on tweakpane, but stops the generated public declarations from importing tweakpane or @tweakpane/core by using local structural types for the devtools APIs that leak into the bundled declarations.

Verification:

  • npm run build-dts
  • npm run tsc
  • npx eslint --cache src/ui/control/devtools.ts
  • npm run test-typings

@2lll5 2lll5 requested a review from a team as a code owner June 11, 2026 05:36
@2lll5 2lll5 requested review from dcoj and removed request for a team June 11, 2026 05:36
@CLAassistant

CLAassistant commented Jun 11, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

Hey, @2lll5 👋 Thanks for your contribution to Mapbox GL JS!

Important: This repository does not accept direct merges. All changes go through our internal review process.

What happens next:

  1. A team member will review your PR here first
  2. If it looks good, they will import it to our internal repository for further review
  3. If approved, changes will be synced back here via our release process

Please respond to any review comments on this PR. For more details, see CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build application due to missing type declarations

2 participants