Added missing include guards. Fixes a lot of compile issues.#39
Open
SimonCahill wants to merge 4 commits intomapbox:masterfrom
Open
Added missing include guards. Fixes a lot of compile issues.#39SimonCahill wants to merge 4 commits intomapbox:masterfrom
SimonCahill wants to merge 4 commits intomapbox:masterfrom
Conversation
Update README.md
Fixed the Makefile generator so it can actually be used in Cmake projects without ruining everything and building tests which I don't need.
To use:
```
add_subdirectory(gzip-hpp)
target_link_libraries(
mybin
gzip-hpp
)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headers provided are generally missing include guards.
This led to many compiler issues in a few projects.
I've added basic include guards, so this doesn't happen in future and ugly hacks like this aren't needed: