CLOUDPLAT-3162: disable run-tests in npm-release workflow#171
Merged
Conversation
Tests require cfn-lint (Python) which is not available in the reusable workflow runner. Tests are already enforced on every PR via the separate test.yml workflow. https://mapbox.atlassian.net/browse/CLOUDPLAT-3162
|
Successfully scanned changes introduced in a pull request into Internal scan identifier:
See all issues found during this scan in the OX Security Application. Detailed information
1 aggregation
|
ryndaniels
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
npm-release.ymlworkflow was failing becausetest/shortcuts.test.jscallscfn-lint(a Python tool) which isn't installed in the reusable workflow's runner. The existingtest.ymlCI workflow handles this by installing Python andcfn-lintviarequirements.dev.txtbefore running tests.Since tests are already enforced on every PR merge via
test.yml, there's no need to re-run them at publish time. Addingrun-tests: falseskips the test step in the publish workflow.Ticket: https://mapbox.atlassian.net/browse/CLOUDPLAT-3162