Skip to content

Conversation

@Sella-GH
Copy link

@Sella-GH Sella-GH commented Jan 21, 2026

Hello,

this Library is featured in the Microsoft Documentation about ASP.NET Core Identity Multi-Factor Authentication.

Then I looked over the repo and saw that the package is mainly available and compiled for .NET 6. In the state of it being EoL since November 2024 I took the little effort to upgrade the TFMs to support .NET 8 and .NET 10 too. I also upgraded the NuGet packages so they're being available in the newest versions.

All tests are passing despite the .NET 6 ones won't even run, it just discovers no test available strangely.
image

Open Question

Since all of the Demo projects currently build as .NET 8 compatible my suggestion would be to throw out .NET 6 completely and only support the current LTS versions. This also allows to use newer Language Features like Collection Expressions etc.

Copilot AI review requested due to automatic review settings January 21, 2026 18:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@manuelbl
Copy link
Owner

Thanks for your PR. I will look into it.

For the library itself, there is probably no advantage in building it for a more recent .NET version. It's compatible anyway. The only reason it is built for .NET 6 and not just for .NET Standard 2.0 is that trimming was a requested feature and trimming is only available starting with .NET 6.

The examples are different. It could make sense to upgrade them. But at the same time, there are a lot of library users that still use .NET Framework 4.x. If they use the examples, they already have to downgrade the code to older language features. Likely, some of the examples needs both a .NET Framework 4.x version and one with a recent version of C#.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants