fix: KNN configuration parsing in plain mode to make dimensions optional based on model name#4119
Merged
sanikolaev merged 3 commits intomasterfrom Jan 12, 2026
Merged
fix: KNN configuration parsing in plain mode to make dimensions optional based on model name#4119sanikolaev merged 3 commits intomasterfrom
sanikolaev merged 3 commits intomasterfrom
Conversation
4 tasks
glookka
requested changes
Jan 9, 2026
Contributor
glookka
left a comment
glookka
left a comment
There was a problem hiding this comment.
Code is ok. However, we already have an embeddings-specific test_306, there's no need to make another test dependent on embeddings library
sanikolaev
force-pushed
the
issue-4118
branch
3 times, most recently
from
d186820 to
47c259a
Compare
…nal based on model name; update test cases for new behavior Related issue #4118
Collaborator
Author
test_306 requires RT mode, and I could not find a way to make it work in both modes. Because of that, I moved the new test actions to a new test 419 (rebased the commits too). |
glookka
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #4118