float comparison functions with tolerance in ubertests#3966
Merged
sanikolaev merged 5 commits intomasterfrom Jan 14, 2026
Merged
float comparison functions with tolerance in ubertests#3966sanikolaev merged 5 commits intomasterfrom
sanikolaev merged 5 commits intomasterfrom
Conversation
Implemented functions to compare floats and strings containing floats with tolerance which is required for different CPU architectures, allowing for more flexible equality checks. Added a global flag to disable float tolerance for strict comparisons.
Contributor
|
Test suite already has RoundFloatValues that is used for some cases, why not use it specifically for knn_dist case? |
Collaborator
Author
Good idea. Done in 4460855 |
glookka
requested changes
Nov 29, 2025
Contributor
glookka
left a comment
There was a problem hiding this comment.
New version is better, however, it disables all float rounding using that new flag. This is wrong because RoundFloatValues must be used to round values in json result sets irregardless of the flag.
Collaborator
Author
glookka
requested changes
Jan 11, 2026
Contributor
|
As discussed, let's make this rounding mode disabled by default |
Collaborator
Author
Done in |
glookka
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented functions to compare floats and strings containing floats with tolerance which is required for different CPU architectures, allowing for more flexible equality checks. Added a global flag to disable float tolerance for strict comparisons.
Master branch:
Branch ubertest/float-tolerance