This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Hide libcurl internally instead of wrapping #168
Draft
Hind-M wants to merge 5 commits intomamba-org:mainfrom
Draft
Hide libcurl internally instead of wrapping #168Hind-M wants to merge 5 commits intomamba-org:mainfrom
Hind-M wants to merge 5 commits intomamba-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #159
TODO:
Two points still need to be handled (maybe after completing powerloader integration in mamba? - mostly for the first one):
ssl_backend_tenum conversion to use outside powerloader.progress_callback_t = std::function<int(curl_off_t, curl_off_t)>indownload_target.hppis apparently used in mamba withstd::size_tinstead ofcurl_off_t. So I don't see whycurl_off_tis used here.If there is no specific reason, it should directly use
std::size_t.