cli: migrate multicastgroup, allowlist, user, and globalconfig verbs to async#3789
Merged
Merged
Conversation
juan-malbeclabs
force-pushed
the
jo/cli-multicast-user-globalconfig-async
branch
from
1538cdb to
daab059
Compare
juan-malbeclabs
force-pushed
the
jo/cli-device-link-async
branch
2 times, most recently
from
7146659 to
a0a4b34
Compare
juan-malbeclabs
force-pushed
the
jo/cli-multicast-user-globalconfig-async
branch
from
daab059 to
dad3d1b
Compare
juan-malbeclabs
force-pushed
the
jo/cli-device-link-async
branch
from
a0a4b34 to
03dd64b
Compare
juan-malbeclabs
force-pushed
the
jo/cli-multicast-user-globalconfig-async
branch
2 times, most recently
from
f92824b to
fb3f8bf
Compare
juan-malbeclabs
force-pushed
the
jo/cli-device-link-async
branch
2 times, most recently
from
9a9618b to
5026122
Compare
…to async Flip the 5 multicastgroup CRUD verbs (create, update, list, get, delete), 6 multicastgroup allowlist verbs (publisher + subscriber add/list/remove), 6 foundation/QA allowlist verbs, 8 user verbs (create, create-subscribe, subscribe, request-ban, update, list, get, delete), and 9 globalconfig verbs and sub-tree verbs (get, set, set- version, airdrop get/set, authority get/set, feature-flags get/set) to the RFC-20 async fn execute(self, ctx, client, out) signature. MulticastGroupCommands::execute itself flips from sync to async and propagates ctx through nested allowlist arms; the binary's Multicast arm becomes args.command.execute(&ctx, &client, &mut handle).await. Signature-only sweep: verb bodies (--wait polling, multicastgroup update re-fetch) are unchanged. Test files gain the per-file block_on shim and cli_context_default_for_tests() import. The doublezero binary, admin, and the serviceability dispatcher all forward ctx and await every multicastgroup, allowlist, user, and globalconfig arm. All 345 unit tests pass byte-identically.
…nd globalconfig verb tests Drop the per-verb local block_on copies in favor of the doublezero_cli_core::testing::block_on helper lifted in the location PR, matching the location reference verb.
juan-malbeclabs
force-pushed
the
jo/cli-multicast-user-globalconfig-async
branch
from
a04462b to
ad08eea
Compare
ben-dz
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #3787 → ... → #3782. Review and merge in order; this is the last PR in the sequence — after it merges, every serviceability verb is on the RFC-20 `async fn execute(self, ctx, client, out)` contract.
Related RFC: RFC-20 CLI standardization.
Testing Verification