Skip to content

smartcontract: allow feed authority to operate on non-owned access passes#3298

Draft
snormore wants to merge 2 commits intomainfrom
snor/feed-authority-non-owner-access-pass
Draft

smartcontract: allow feed authority to operate on non-owned access passes#3298
snormore wants to merge 2 commits intomainfrom
snor/feed-authority-non-owner-access-pass

Conversation

@snormore
Copy link
Contributor

@snormore snormore commented Mar 17, 2026

Summary of Changes

  • Remove ownership checks that restricted the feed authority to only update/modify access passes it created
  • The feed authority needs to manage access passes created by other authorities in the scenario where the user is already connected to a multicast group

Diff Breakdown

Category Files Lines (+/-) Net
Core logic 2 +1 / -17 -16
Tests 1 +8 / -18 -10
Docs 1 +2 / -0 +2

Mostly removing restriction code and updating tests to verify non-owner operation.

Key files (click to expand)
  • smartcontract/.../accesspass/set.rs — remove ownership check on SetAccessPass updates
  • smartcontract/.../subscriber/add.rs — remove ownership check on subscriber allowlist modifications
  • smartcontract/.../multicastgroup_allowlist_subcriber_test.rs — update tests so feed authority operates on access passes it doesn't own

Testing Verification

  • Existing feed authority subscriber allowlist tests updated to exercise non-owner scenario and pass

…sses

Remove ownership checks that restricted the feed authority to only
modify or update access passes it created. The feed authority needs
to manage access passes created by other authorities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant