fix(utils): keep 0 alpha in oklchToCSS output - #9556
Open
Arunendra21 wants to merge 1 commit into
Open
Conversation
oklchToCSS appended the alpha channel only when `alpha` was truthy, so an alpha of 0 (fully transparent) was dropped and the colour rendered opaque. This affects the alpha theme tokens generated in theme-application.ts, where alpha is passed as `value * 100`. Guard with `alpha != null` so 0 is emitted as `/ 0.00%` while an omitted alpha still produces no alpha channel. Co-authored-by: eeshsaxena <eeshsaxena@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesColor conversion
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
oklchToCSS(packages/utils/src/theme/color-conversion.ts) appends the alpha channel only whenalphais truthy:`...${alpha ? ` / ${alpha.toFixed(2)}%` : ""})`Because
0is falsy, an alpha of0(fully transparent) is dropped and the colour renders opaque instead of transparent:This is reachable via
theme-application.ts, which builds the--alpha-white-*/--alpha-black-*tokens withoklchToCSS(neutralOKLCH, value * 100)— a0alpha token would come out opaque.Fix
Guard with
alpha != nullso0is emitted while an omittedalphastill produces no alpha channel. Verified againstalpha = 0, a positive alpha, and an omitted alpha. (packages/utilshas no unit-test runner configured, so no test file is included.)Summary by CodeRabbit