Modularize and improve code structure (1/T)#3
Open
AlphaV7 wants to merge 12 commits intomaisonm:masterfrom
Open
Modularize and improve code structure (1/T)#3AlphaV7 wants to merge 12 commits intomaisonm:masterfrom
AlphaV7 wants to merge 12 commits intomaisonm:masterfrom
Conversation
- store all config in a separate file at the server - add utility function to make API calls - store urls and url config in a separate file - define utility funtions used by the client in a separate file The urls should be stored in a separate place. Hard-coding urls leads to greater dependencies and will lead to unmanagable code. functions that can be used again should be stored as a utility function
- store all config in a separate file at the server - add utility to make API calls - store url and url config in a separate file - define utility functions used at client in a separate file The urls should be stored in a separate place. Hard-coding urls leads to greater dependencies and will lead to unmanagable code. functions that can be used again should be stored as a utility
- add options to retrive weather information b additional remaining methods: city-name, city-id and city-coordinates - changed apis used in server side and reduces functionality to a single api call
AlphaV7
changed the title
- create necessary actions and reducers to perfom state updation for Home container - remove dependency between the parent container and child compoent and have a common store to fetch data from
modularize client code to store containers and components separately
Intigrate react-redux in weather app
Merge redux integration and client code change from develop
- added saga for making API calls - modularized components in CurrentWeather container - configured eslint for es6 syntax - removed internal state dependency from component
Integrate redux saga in weather app
Integrate redux and redux saga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The urls should be stored in a separate place. Hard-coding urls leads to
greater dependencies and will lead to unmanagable code. functions that
can be used again should be stored as a utility