-
Notifications
You must be signed in to change notification settings - Fork 7
Coderabbit config test #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
| language: en | ||
| reviews: | ||
| path_instructions: | ||
| - path: "spec/fixtures/vcr_cassettes/**/*.yml" | ||
| instructions: | | ||
| Act as a data privacy officer. Carefully read all the vcr cassettes | ||
| with recorded HTTP interactions and try to identify sensitive data that | ||
| could potentially be recorded. It can be anything from PII to | ||
| credentials. Ignore obvious placeholder values. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module Mailtrap | ||
| # Data Transfer Object for SandboxAttachment | ||
| # @see https://docs.mailtrap.io/developers/email-sandbox/email-sandbox-api/attachments | ||
| # @attr_reader id [Integer] The project ID | ||
| # @attr_reader message_id [Integer] The message ID | ||
| # @attr_reader filename [String] The attachment filename | ||
| # @attr_reader attachment_type [String] The attachment type | ||
| # @attr_reader content_type [String] The attachment content type | ||
| # @attr_reader content_id [String] The attachment content ID | ||
| # @attr_reader transfer_encoding [String] The attachment transfer encoding | ||
| # @attr_reader attachment_size [Integer] The attachment size in bytes | ||
| # @attr_reader created_at [String] The attachment creation timestamp | ||
| # @attr_reader updated_at [String] The attachment update timestamp | ||
| # @attr_reader attachment_human_size [String] The attachment size in human-readable format | ||
| # @attr_reader download_path [String] The attachment download path | ||
| # | ||
| SandboxAttachment = Struct.new( | ||
| :id, | ||
| :message_id, | ||
| :filename, | ||
| :attachment_type, | ||
| :content_type, | ||
| :content_id, | ||
| :transfer_encoding, | ||
| :attachment_size, | ||
| :created_at, | ||
| :updated_at, | ||
| :attachment_human_size, | ||
| :download_path, | ||
| keyword_init: true | ||
| ) do | ||
| # @return [Hash] The Project attributes as a hash | ||
| def to_h | ||
| super.compact | ||
| end | ||
| end | ||
| end | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require_relative 'base_api' | ||
| require_relative 'sandbox_attachment' | ||
|
|
||
| module Mailtrap | ||
| class SandboxAttachmentsAPI | ||
| include BaseAPI | ||
|
|
||
| self.response_class = SandboxAttachment | ||
|
|
||
| # Retrieves a specific sandbox attachment | ||
| # @param inbox_id [Integer] The inbox ID | ||
| # @param sandbox_message_id [Integer] The sandbox message ID | ||
| # @param sandbox_attachment_id [Integer] The sandbox attachment ID | ||
| # @return [SandboxAttachment] Sandbox attachment object | ||
| # @!macro api_errors | ||
| def get(inbox_id, sandbox_message_id, sandbox_attachment_id) | ||
| response = client.get( | ||
| "#{base_path}/inboxes/#{inbox_id}/messages/#{sandbox_message_id}/attachments/#{sandbox_attachment_id}" | ||
| ) | ||
| handle_response(response) | ||
| end | ||
|
|
||
| # Lists all sandbox messages for the account, limited up to 30 at once | ||
| # @param inbox_id [Integer] The inbox ID | ||
| # @param sandbox_message_id [Integer] The sandbox message ID | ||
| # @return [Array<SandboxAttachment>] Array of sandbox message objects | ||
| # @!macro api_errors | ||
| def list(inbox_id, sandbox_message_id) | ||
| response = client.get("#{base_path}/inboxes/#{inbox_id}/messages/#{sandbox_message_id}/attachments") | ||
| response.map { |item| handle_response(item) } | ||
|
Comment on lines
+25
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct docstring to reference attachments (not messages). Line 25 says “sandbox messages” but this method lists attachments. ✏️ Proposed fix- # Lists all sandbox messages for the account, limited up to 30 at once
+ # Lists all sandbox attachments for the account, limited up to 30 at once🤖 Prompt for AI Agents |
||
| end | ||
|
|
||
| private | ||
|
|
||
| def base_path | ||
| "/api/accounts/#{account_id}" | ||
| end | ||
| end | ||
| end | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix docstrings that reference “project” instead of attachment.
The DTO docs mention “project” for
idandto_h, which conflicts with the attachment model.✏️ Suggested docstring correction
📝 Committable suggestion
🤖 Prompt for AI Agents