-
Notifications
You must be signed in to change notification settings - Fork 1
[Simple Analytics] Add Data Layer & Form Event Tracking #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alaca
wants to merge
14
commits into
feature/analytics-admin-page
Choose a base branch
from
feature/data-layer-and-form-event-tracking
base: feature/analytics-admin-page
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
32e9d80
initial commit
alaca fd8d824
Update includes/admin/templates/analytics.php
alaca fd10548
Update includes/class-mailchimp-analytics-data.php
alaca af36860
Update includes/admin/templates/analytics.php
alaca c9e70bf
Update assets/js/mailchimp.js
alaca db85ff8
Update includes/class-mailchimp-analytics-data.php
alaca d502e39
refactor: admin nonce
alaca 2910bf8
refactor: log error
alaca 7e0cb95
Merge branch 'feature/analytics-admin-page' into feature/data-layer-a…
alaca b912629
refactor: remove copilot suggestion
alaca b7a201d
feature: add get analytics ajax action
alaca dfa1f5d
feature: localize mailchimpSFAnalytics
alaca 2275cc9
feature: add fetchAnalyticsData
alaca 8d5d146
refactor: remove activation hook
alaca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contentArea.innerHTML = JSON.stringify(data)usesinnerHTMLwith server-provided content, which is unnecessary and can introduce XSS risks if the payload ever contains user-controlled strings. Prefer assigning totextContentfor raw JSON output, or render into DOM nodes with proper escaping.