Modernize code and update to support newer versions of RN without warnings.#7
Open
markrickert wants to merge 6 commits intomagrinj:masterfrom
Open
Modernize code and update to support newer versions of RN without warnings.#7markrickert wants to merge 6 commits intomagrinj:masterfrom
markrickert wants to merge 6 commits intomagrinj:masterfrom
Conversation
componentWillMount is deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things to update the code and modernize the component.
This is the best component I've found for swiping rows in a
Flatlist(all the other libraries make you style all the hidden elements yourself) so I wanted to stick with this library but it needed a little TLC to make it work with new versions ofReactsince there are lots of deprecated lifecycle methods.PanResponderto theconstructormethod sincecomponentDidMountis deprecated.componentWillReceivePropstocomponentDidUpdate1.0.0would only auto-close theSwipeRowwhen the propertyisOpenchanged fromtrue->false. I added a contition that allows you to animate the buttons open or closed so that<SwipeRow isOpen={true} />will animate the row open if it is not.1.0.0if you're using React Native< 0.54.I hope you like these changes and integrate them into this really useful and user-friendly library!