Adding support for rendering React component#131
Open
pawan52tiwari wants to merge 2 commits intomagicismight:masterfrom
Open
Adding support for rendering React component#131pawan52tiwari wants to merge 2 commits intomagicismight:masterfrom
pawan52tiwari wants to merge 2 commits intomagicismight:masterfrom
Conversation
Current ToastContainer.js class can only render Text elements We can use View as a container if the child is not a text to render react component.
Author
|
@magicismight Can you please review this cr |
|
To avoid using the forked package, I used patch-package to generate this diff and apply it on diff --git a/node_modules/react-native-root-toast/lib/ToastContainer.js b/node_modules/react-native-root-toast/lib/ToastContainer.js
index a645d4d..0f03cc9 100644
--- a/node_modules/react-native-root-toast/lib/ToastContainer.js
+++ b/node_modules/react-native-root-toast/lib/ToastContainer.js
@@ -255,13 +255,13 @@ class ToastContainer extends Component {
pointerEvents="none"
ref={ele => this._root = ele}
>
- <Text style={[
+ {typeof this.props.children === 'string' ? <Text style={[
styles.textStyle,
props.textStyle,
props.textColor && {color: props.textColor}
]}>
{this.props.children}
- </Text>
+ </Text> : this.props.children}
</Animated.View>
</TouchableWithoutFeedback>
</View> : null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current ToastContainer.js class can only render Text elements We can use View as a container if the child is not a text to render react component.