Skip to content

Update Options.php#1

Open
kkkonrad wants to merge 1 commit into
magesuite:1.xfrom
kkkonrad:patch-1
Open

Update Options.php#1
kkkonrad wants to merge 1 commit into
magesuite:1.xfrom
kkkonrad:patch-1

Conversation

@kkkonrad
Copy link
Copy Markdown

No description provided.

@diwipl
Copy link
Copy Markdown
Contributor

diwipl commented Apr 23, 2020

Hi,
Thank you for contributing to MageSuite.
Unfortunately we will not accept this pull request, it is our idea to have whole label passed to translation function. That way we can using only CSV translation files change "Price - Descending" to for example "From the lowest price" or "Lowest price first". Without having attribute label in it, it would be impossible.

@kkkonrad
Copy link
Copy Markdown
Author

ok but there is problem with custom attribute translation, where user can translate attribute name from admin panel but not - Descending or - Ascending part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants